Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] account-invoicing: account_invoice_tax_note #1616

Conversation

MarinaAForgeFlow
Copy link

Supersedes PR #1477

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I need to update my last review. There is no way to check or edit the note from the tax groups menus.

image

@JordiMForgeFlow
Copy link
Contributor

@MarinaAForgeFlow could you rebase?

@MarinaAForgeFlow MarinaAForgeFlow force-pushed the 16.0-mig-account_invoicing-account_invoice_tax_note branch from 912dead to c7bac7c Compare February 27, 2024 08:15
acsonefho and others added 19 commits February 27, 2024 10:16
Currently translated at 100.0% (7 of 7 strings)

Translation: account-invoicing-15.0/account-invoicing-15.0-account_invoice_tax_note
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-15-0/account-invoicing-15-0-account_invoice_tax_note/ca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-15.0/account-invoicing-15.0-account_invoice_tax_note
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-15-0/account-invoicing-15-0-account_invoice_tax_note/
Currently translated at 100.0% (4 of 4 strings)

Translation: account-invoicing-15.0/account-invoicing-15.0-account_invoice_tax_note
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-15-0/account-invoicing-15-0-account_invoice_tax_note/es/
@MarinaAForgeFlow MarinaAForgeFlow force-pushed the 16.0-mig-account_invoicing-account_invoice_tax_note branch from c7bac7c to 1e89bb3 Compare February 27, 2024 09:20
Copy link
Contributor

@JordiMForgeFlow JordiMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code + functional review

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1616-by-AaronHForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 27, 2024
Signed-off-by AaronHForgeFlow
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-1616-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 971b44a into OCA:16.0 Feb 27, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2ab78d7. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.