Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] account_invoice_refund_reason: Migration to 16.0 #1612

Merged
merged 32 commits into from
Dec 5, 2023
Merged

[16.0][MIG] account_invoice_refund_reason: Migration to 16.0 #1612

merged 32 commits into from
Dec 5, 2023

Conversation

BT-anieto
Copy link

#1494 is stale, so I take it

Chanakya-SerpentCS and others added 30 commits November 21, 2023 15:42
@Chanakya-SerpentCS @BT-anieto
[12.0][ADD] Initial Commit
0834729
@max3903 @BT-anieto
[IMP] account_invoice_refund_reason
8289d32
@max3903 @BT-anieto
[FIX] account_invoice_refund_reason: Duplicate label
17e6379
@Chanakya-SerpentCS @BT-anieto
[IMP] Improved code
1cda908
@Chanakya-SerpentCS @BT-anieto
[ADD] Added Unit Test
ed6a464
@Chanakya-SerpentCS @BT-anieto
[FIX] Fixed Travis
f501c13
@Chanakya-SerpentCS @max3903 @BT-anieto
Update account_invoice_refund_reason/tests/test_account_invoice_refun…
fb343e2 
…d_reason.py

Co-Authored-By: Maxime Chambreuil <[email protected]>
@Chanakya-SerpentCS @BT-anieto
[Fix] Travis & Typo
f29d2bf
@BT-anieto
Update __init__.py
ac858fc
@Chanakya-SerpentCS @BT-anieto
Update account_invoice_refund_reason/wizard/account_invoice_refund.py
95befe4 
Co-Authored-By: Maxime Chambreuil <[email protected]>
@Chanakya-SerpentCS @BT-anieto
Update account_invoice_refund_reason/wizard/account_invoice_refund.py
d306127 
Co-Authored-By: Maxime Chambreuil <[email protected]>
@Chanakya-SerpentCS @BT-anieto
Update account_invoice_refund_reason/tests/test_account_invoice_refun…
e11f67b 
…d_reason.py

Co-Authored-By: Maxime Chambreuil <[email protected]>
@max3903 @BT-anieto
[FIX] account_invoice_refund_reason
5eddd43
@Chanakya-SerpentCS @BT-anieto
[FIX] Fixed Travis
1581c4e
@BT-anieto
Added translation using Weblate (Spanish)
7c79420
@badbole @BT-anieto
Added translation using Weblate (Croatian)
ef9595c
@sergiocorato @BT-anieto
[12.0][FIX] too generic xpath expr
0210e50
@marylla @BT-anieto
Added translation using Weblate (German)
c0cc221
@anasuarez1 @BT-anieto
Translated using Weblate (Spanish)
fa2d9c2 
Currently translated at 100.0% (21 of 21 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_refund_reason
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_refund_reason/es/
@JaumeBforgeFlow @BT-anieto
[13.0][IMP] account_invoice_refund_reason: black, isort, prettier
f091149
@JaumeBforgeFlow @BT-anieto
[13.0][MIG] account_invoice_refund_reason: Migration to 13.0
80571ec
@JaumeBforgeFlow @BT-anieto
[IMP] account_invoice_refund_reason: active and description fields
f98bd0d
@ChrisOForgeFlow @BT-anieto
[IMP] account_invoice_refund_reason: black, isort, prettier
3b68d50
@ChrisOForgeFlow @BT-anieto
[14.0][MIG] account_invoice_refund_reason
a16f46e
@MiquelRForgeFlow @Hardik-OSI
@Freni-OSI @Reyes4711-S73 @BT-anieto
[IMP] account_invoice_refund_reason: improvements
5d6f962 
Co-authored-by: Hardik-OSI <[email protected]>
Co-authored-by: Freni-OSI <[email protected]>
Co-authored-by: Reyes4711 <[email protected]>
@ChrisOForgeFlow @BT-anieto
[15.0][MIG] account_invoice_refund_reason
426b03e
@JaumeBforgeFlow @BT-anieto
[FIX] account_invoicing_refund_reason: refund and new draft invoice
6ec2d59
@JordiMForgeFlow @BT-anieto
[IMP] account_invoice_refund_reason: add field filters
316a808
@HviorForgeFlow @BT-anieto
[FIX] account_invoice_refund_reason: Fix tests
1f130fe
@Ivorra78 @BT-anieto
Translated using Weblate (Spanish)
f7e89c2 
Currently translated at 100.0% (24 of 24 strings)

Translation: account-invoicing-15.0/account-invoicing-15.0-account_invoice_refund_reason
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-15-0/account-invoicing-15-0-account_invoice_refund_reason/es/
@BT-anieto BT-anieto mentioned this pull request Nov 21, 2023
Merged
BT-dherreros
BT-dherreros approved these changes Nov 21, 2023
View reviewed changes
Copy link

@BT-dherreros BT-dherreros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BT-nfrancisco
BT-nfrancisco approved these changes Nov 21, 2023
View reviewed changes
Copy link

@BT-nfrancisco BT-nfrancisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@BT-anieto
Copy link
Author

@OCA/accounting-maintainers Good for merge?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@BT-anieto
Copy link
Author

@max3903 Could we merge it?

@BT-anieto
Copy link
Author

Good morning @pedrobaeza. Sorry to bother you, but neither the accounting maintainers nor the module maintainers answer me.

Could we merge this PR?

@pedrobaeza
Copy link
Member

You should respect commit attribution from #1494 instead of overwriting everything, and include him in CONTRIBUTORS.rst, the same you have made with you.

@BT-anieto BT-anieto force-pushed the 16.0-mig-account_invoice_refund_reason branch from ec0da7d to 3a37c54 Compare December 4, 2023 08:57
@BT-anieto
Copy link
Author

Not sure about having done everything right. I added him as author of the last two commits, although I included myself in CONTRIBUTORS.rst in the last one. Is it proper?

1 similar comment
@BT-anieto
Copy link
Author

Not sure about having done everything right. I added him as author of the last two commits, although I included myself in CONTRIBUTORS.rst in the last one. Is it proper?

@pedrobaeza pedrobaeza mentioned this pull request Dec 5, 2023
Closed
pedrobaeza
pedrobaeza approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot migration account_invoice_refund_reason
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Dec 5, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 5, 2023
Open
65 tasks
@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1612-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1e52a59 into OCA:16.0 Dec 5, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 935e845. Thanks a lot for contributing to OCA. ❤️

@BT-anieto BT-anieto deleted the 16.0-mig-account_invoice_refund_reason branch December 7, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BT-nfrancisco BT-nfrancisco BT-nfrancisco approved these changes

@BT-dherreros BT-dherreros BT-dherreros approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.