Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] account_invoice_payment_term_date_due: Migration to 16.0 #1607

Merged
merged 5 commits into from
Dec 4, 2023
Merged

[16.0][MIG] account_invoice_payment_term_date_due: Migration to 16.0 #1607

merged 5 commits into from
Dec 4, 2023

Conversation

BT-anieto
Copy link

@BT-anieto BT-anieto commented Nov 16, 2023 •
edited
Loading

#1476 and #1473 are stale, so I take it.

@BT-anieto BT-anieto force-pushed the 16.0-mig-account_invoice_payment_term_date_due branch from 6be5975 to b397c73 Compare November 16, 2023 17:16
@BT-anieto
Copy link
Author

Hello @ivantodorovich Could you take a look at this PR? I do not know why tests are failing. I don't get the error message.

@BT-anieto BT-anieto force-pushed the 16.0-mig-account_invoice_payment_term_date_due branch from b397c73 to 0179ae8 Compare November 16, 2023 17:28
@BT-anieto
Copy link
Author

@OCA/accounting-maintainers Hello. Could anyone tell me why the tests are failing? Thank you very much

@BT-anieto BT-anieto closed this Nov 21, 2023
@BT-anieto BT-anieto reopened this Nov 21, 2023
@BT-anieto BT-anieto force-pushed the 16.0-mig-account_invoice_payment_term_date_due branch from 0179ae8 to d7c7672 Compare November 21, 2023 11:53
BT-dherreros
BT-dherreros approved these changes Nov 21, 2023
View reviewed changes
Copy link

@BT-dherreros BT-dherreros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BT-pcavero
BT-pcavero approved these changes Nov 21, 2023
View reviewed changes
Copy link

@BT-pcavero BT-pcavero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@BT-anieto
Copy link
Author

@OCA/accounting-maintainers Good for merge?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@BT-anieto
Copy link
Author

Good morning @pedrobaeza. Sorry to bother you, but neither the accounting maintainers nor the module maintainers answer me.

Could we merge this PR?

@pedrobaeza pedrobaeza changed the title [MIG] account_invoice_payment_term_date_due: Migration to 16.0 [16.0][MIG] account_invoice_payment_term_date_due: Migration to 16.0 Dec 4, 2023
@pedrobaeza
Copy link
Member

I'm not seeing the changes in cbb3d21#diff-24efa77db9de5fef130c82c8f7db072cf578342dc768017ba2113da1340000d9. Aren't they needed?

@BT-anieto
Copy link
Author

I would say no. This was causing strange render.

@pedrobaeza pedrobaeza mentioned this pull request Dec 4, 2023
Closed
@pedrobaeza
Copy link
Member

/ocabot merge nobump
/ocabot migration account_invoice_payment_term_date_due

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Dec 4, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 4, 2023
Open
65 tasks
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1607-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8a7e724 into OCA:16.0 Dec 4, 2023
4 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f5c4a7b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BT-pcavero BT-pcavero BT-pcavero approved these changes

@BT-dherreros BT-dherreros BT-dherreros approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
7 participants
@BT-anieto @OCA-git-bot @pedrobaeza @BT-dherreros @BT-pcavero @ivantodorovich @polqubiq