Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] account_invoice_alternate_payer #1492

Merged
merged 9 commits into from
Feb 28, 2024
Merged

[16.0][MIG] account_invoice_alternate_payer #1492

merged 9 commits into from
Feb 28, 2024

Conversation

ChrisOForgeFlow
Copy link
Contributor

@ForgeFlow

Removed tests:

  • Onchange methods on moves don't create all lines in same way than older versions, only when post is done system recompute values according display type of lines
  • Payment state is a computed field on account.move can't be written

gerard-vacas
gerard-vacas approved these changes Nov 15, 2023
View reviewed changes
Copy link

@gerard-vacas gerard-vacas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Tested regular and refund invoices in both customer and vendor

@gerard-vacas
Copy link

Hi @ChrisOForgeFlow

Could you force the runboat rebuild so the module can get another approval?

Thank you!

@ChrisOForgeFlow ChrisOForgeFlow force-pushed the 16.0-mig-account_invoice_alternate_payer branch from 14c9cd3 to 10ac703 Compare November 23, 2023 13:05
@ChrisOForgeFlow
Copy link
Contributor Author

Hi @ChrisOForgeFlow

Could you force the runboat rebuild so the module can get another approval?

Thank you!

Done!

@ACheung-FactorLibre
Copy link

Hi @ChrisOForgeFlow, please improve the module's coverage. Thank you!

@ChrisOForgeFlow ChrisOForgeFlow force-pushed the 16.0-mig-account_invoice_alternate_payer branch from 10ac703 to 9894860 Compare December 7, 2023 16:23
@ChrisOForgeFlow ChrisOForgeFlow force-pushed the 16.0-mig-account_invoice_alternate_payer branch from 9894860 to e7eb002 Compare December 12, 2023 14:04
ACheung-FactorLibre
ACheung-FactorLibre approved these changes Dec 12, 2023
View reviewed changes
Copy link

@ACheung-FactorLibre ACheung-FactorLibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

SoniaViciana
SoniaViciana approved these changes Dec 19, 2023
View reviewed changes
Copy link

@SoniaViciana SoniaViciana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM

@ACheung-FactorLibre
Copy link

Hi @pedrobaeza,

Could you review this?

Thank you!

@pedrobaeza
Copy link
Member

Merging blindly according reviews:

/ocabot migration account_invoice_alternate_payer
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Feb 28, 2024
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1492-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Feb 28, 2024
Open
65 tasks
@OCA-git-bot OCA-git-bot merged commit e49ded7 into OCA:16.0 Feb 28, 2024
4 of 5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e375b13. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ACheung-FactorLibre ACheung-FactorLibre ACheung-FactorLibre approved these changes

@gerard-vacas gerard-vacas gerard-vacas approved these changes

@SoniaViciana SoniaViciana SoniaViciana approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
9 participants
@ChrisOForgeFlow @gerard-vacas @ACheung-FactorLibre @OCA-git-bot @pedrobaeza @SoniaViciana @JordiBForgeFlow @etobella @olgamarcocb