[16.0][FIX] account_invoice_triple_discount: discount decimal precision #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Segui-S73
changed the title
|
Please @eantones could you review this PR? |
|
/ocabot rebase |
|
@rafaelbn The rebase process failed, because command |
Segui-S73
force-pushed
the
16.0-fix-account_invoice_triple_discount
branch
from
4591fb6 to
a0a8105
Compare
|
Hi @rafaelbn , I have manually the rebase after seeing the bot error. |
rafaelbn
reviewed
Sep 8, 2023
| @@ -3,7 +3,7 @@ | |||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | |||
| { | |||
| "name": "Account Invoice Triple Discount", | |||
| "version": "16.0.1.0.1", | |||
| "version": "16.0.1.0.2", | |||
There was a problem hiding this comment.
You don't need to update version. This is made by bot automatically.
rafaelbn
approved these changes
Sep 8, 2023
miguel-S73
force-pushed
the
16.0-fix-account_invoice_triple_discount
branch
2 times, most recently
from
5fb6940 to
5a5dfb2
Compare
Segui-S73
force-pushed
the
16.0-fix-account_invoice_triple_discount
branch
from
5a5dfb2 to
41ab75a
Compare
Segui-S73
force-pushed
the
16.0-fix-account_invoice_triple_discount
branch
from
41ab75a to
ee23679
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calculating the triple discount, if there is any raise the decimal precision of the discount field stays at 16, so try except is added to avoid this.