Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][ADD] account_manual_currency #1486

Merged

Conversation

Saran440
Copy link
Member

@Saran440 Saran440 commented Jun 15, 2023

This module allows users to update the currency manually for invoices that are still in the draft stage.

Screenshot from 2023-06-15 11-00-51
Screenshot from 2023-06-15 11-00-58

when register payment, Journal Entry in payment will compute rate from moves
Screenshot from 2023-06-15 11-05-26

TODO:

  • test script

@Saran440 Saran440 changed the title [ADD] account_move_manual_currency [15.0][ADD] account_move_manual_currency Jun 15, 2023
@Saran440 Saran440 force-pushed the 15.0-add-account_move_manual_currency branch from c6136dc to df322b9 Compare June 26, 2023 06:26
@Saran440 Saran440 changed the title [15.0][ADD] account_move_manual_currency [15.0][ADD] account_manual_currency Jun 26, 2023
@tate11
Copy link

tate11 commented Aug 11, 2023

local test OK very good, thanks for your work

odooNextev pushed a commit to odooNextev/account-invoicing that referenced this pull request Sep 29, 2023
Signed-off-by pedrobaeza
Copy link
Member

@HviorForgeFlow HviorForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review 👍

@Saran440 Saran440 force-pushed the 15.0-add-account_move_manual_currency branch 2 times, most recently from 2288ce0 to 589ce16 Compare November 7, 2023 10:20
@Saran440
Copy link
Member Author

Saran440 commented Nov 7, 2023

@HviorForgeFlow Thank you for reviewed. I add test script in this PR already.

@ps-tubtim Can you check, please?

@Saran440 Saran440 force-pushed the 15.0-add-account_move_manual_currency branch 2 times, most recently from 967fd51 to 077ab4c Compare November 7, 2023 11:15
@Saran440
Copy link
Member Author

Saran440 commented Nov 7, 2023

Change name custom_rate to manual_currency_rate
because custom_rate field already exists in module https://github.com/OCA/account-invoicing/tree/15.0/account_invoice_change_currency

Copy link

@cmcreamm cmcreamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion for functional user the word of "Unit" should change to "Currency" to reduce user confusing. Moreover, I suggest that the sentence will be more clarify if we change it to " Currency per (main currency)" for example, 0.5 currency per 1 THB and 25 THB per 1 currency.
Could you please check if this suggestion has a chance to be possible?

Screenshot from 2023-11-23 14-50-30

@Saran440 Saran440 force-pushed the 15.0-add-account_move_manual_currency branch from 077ab4c to cb01fcc Compare November 23, 2023 09:27
@Saran440
Copy link
Member Author

@cmcreamm I change display to Currency per 1 <main company currency>. Can you re-check please?
Selection_001

Copy link

@cmcreamm cmcreamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@kittiu
Copy link
Member

kittiu commented Nov 28, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-1486-by-kittiu-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 36c9af3 into OCA:15.0 Nov 28, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6151c0e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants