-
-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][ADD] account_manual_currency #1486
[15.0][ADD] account_manual_currency #1486
Conversation
c6136dc
to
df322b9
Compare
local test OK very good, thanks for your work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review 👍
2288ce0
to
589ce16
Compare
@HviorForgeFlow Thank you for reviewed. I add test script in this PR already. @ps-tubtim Can you check, please? |
967fd51
to
077ab4c
Compare
Change name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion for functional user the word of "Unit" should change to "Currency" to reduce user confusing. Moreover, I suggest that the sentence will be more clarify if we change it to " Currency per (main currency)" for example, 0.5 currency per 1 THB and 25 THB per 1 currency.
Could you please check if this suggestion has a chance to be possible?
077ab4c
to
cb01fcc
Compare
@cmcreamm I change display to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional test
This PR has the |
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 6151c0e. Thanks a lot for contributing to OCA. ❤️ |
This module allows users to update the currency manually for invoices that are still in the draft stage.
when register payment, Journal Entry in payment will compute rate from moves
TODO: