Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [MIG] analytic_partner #672

Merged
merged 21 commits into from
Aug 30, 2024
Merged

[16.0] [MIG] analytic_partner #672

merged 21 commits into from
Aug 30, 2024

Conversation

gaelTorrecillas
Copy link

@gaelTorrecillas gaelTorrecillas commented Jul 10, 2024 •
edited
Loading

Hi,

I fork this pr #609 and I add all your recommendations.

pedrobaeza and others added 20 commits November 18, 2023 13:46
@pedrobaeza @dreispt
[ADD] analytic_partner
9a776e6 
Classify analytic items by partner
==================================

This module adds a partner on each analytic item for allowing to have another
dimension for analysing data.

It also handles the proper propagation of this field to the created analytic
entries when validating invoices.

Configuration
=============

You have to be granted as at least "Accountant" in your user profile and
have checked the "Analytic Accounting" access right.

Usage
=====

Go to Accounting > Analytic Journal Items, and there, you can set the partner
for the analytic items, and search or group by it.

You can also go to a partner, and click on the smart-button "Cost/Revenue",
placed on the upper-right part, and you will navigate to the analytic items
associated to this partner.

Known issues / Roadmap
======================

* This module hasn't been tested with *account_analytic_plans* module
installed, so maybe it's incompatible with it.
@pedrobaeza @dreispt
[FIX+IMP] analytic_partner:
564b7be 
* IMP: Distinguish between the partner of the account and the specific partner
* FIX: Allow grouping on partner_id field. Fixes OCA#41
* FIX: README - Indentation is not correct in Known issues.
@oca-transbot @dreispt
OCA Transbot updated translations from Transifex
5fd4a74
@luismontalba @dreispt
[MIG] analytic_account: Migrated to 10.0
58c33d2
@oca-transbot @dreispt
OCA Transbot updated translations from Transifex
e0341e2
@cristinamartinrod @dreispt
[11.0][MIG] analytic_partner: Migration to 11.0
d7d5563
@sergio-teruel @dreispt
[MIG] analytic_partner: Migration to 12.0
d58ac7e
@mvrodriguez @dreispt
Translated using Weblate (Galician)
dd66e2c 
Currently translated at 100.0% (5 of 5 strings)

Translation: account-analytic-12.0/account-analytic-12.0-analytic_partner
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-analytic_partner/gl/
@dreispt
Translated using Weblate (Catalan)
2ec37ac 
Currently translated at 100.0% (5 of 5 strings)

Translation: account-analytic-12.0/account-analytic-12.0-analytic_partner
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-analytic_partner/ca/
@marcelsavegnago @dreispt
Translated using Weblate (Portuguese (Brazil))
4bb884c 
Currently translated at 100.0% (5 of 5 strings)

Translation: account-analytic-12.0/account-analytic-12.0-analytic_partner
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-analytic_partner/pt_BR/
@liweijie0812 @dreispt
Translated using Weblate (Chinese (Simplified))
e46cc3e 
Currently translated at 100.0% (5 of 5 strings)

Translation: account-analytic-12.0/account-analytic-12.0-analytic_partner
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-analytic_partner/zh_CN/
@ps-tubtim @dreispt
[IMP] analytic_partner: black, isort
f3994c3
@ps-tubtim @dreispt
[MIG] analytic_partner: Migration to 13.0
7d67982
@CarlosRoca13 @dreispt
[IMP] analytic_partner: black, isort
e9116b3
@CarlosRoca13 @dreispt
[MIG] analytic_partner: Migration to v14.0
2490de0
@oca-travis @dreispt
[UPD] Update analytic_partner.pot
8476070
@OCA-git-bot @dreispt
[UPD] README.rst
920444b
@Yvesldff @dreispt
Added translation using Weblate (French (France))
56298a1
@Yvesldff @dreispt
Translated using Weblate (French)
ba337fa 
Currently translated at 100.0% (5 of 5 strings)

Translation: account-analytic-14.0/account-analytic-14.0-analytic_partner
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-14-0/account-analytic-14-0-analytic_partner/fr/
@Yvesldff @dreispt
Translated using Weblate (French (France))
d4697a9 
Currently translated at 87.5% (7 of 8 strings)

Translation: account-analytic-14.0/account-analytic-14.0-analytic_partner
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-14-0/account-analytic-14-0-analytic_partner/fr_FR/
@flotho
Copy link
Member

flotho commented Jul 11, 2024

Hi @gaelTorrecillas
thanks for this PR.
First of all, could you please change the PR name and the commit names with a rebase to follow the guidelines https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#git
Then for your re commit issue, could you run pre-commit run --all-files and commit the result in a dedicated commit for lint

@gaelTorrecillas gaelTorrecillas force-pushed the heliaktiv-16.0-mig-analytic_partner branch from 8223154 to 6d4a562 Compare July 11, 2024 13:55
@flotho
Copy link
Member

flotho commented Jul 11, 2024

Hi @gaelTorrecillas
Thanks for this PR .
Codecov is sometimes weird as I discovered with @pedrobaeza
My proposal is that you rename your PR and commits following the guidelines and then we'll be able to make a proper review and maybe we'll have better ideas for the codecov regression.

Regards

@gaelTorrecillas gaelTorrecillas force-pushed the heliaktiv-16.0-mig-analytic_partner branch from 2676ee5 to 91ba837 Compare July 12, 2024 07:44
@flotho
Copy link
Member

flotho commented Jul 12, 2024

Hi @gaelTorrecillas thanks, could you change the PR name please?

@gaelTorrecillas gaelTorrecillas changed the title WIP Heliaktiv 16.0 mig analytic partner [16.0] [MIG] analytic_partner Jul 12, 2024
peluko00
peluko00 suggested changes Jul 22, 2024
View reviewed changes
analytic_partner/__manifest__.py Outdated Show resolved Hide resolved
@gaelTorrecillas gaelTorrecillas force-pushed the heliaktiv-16.0-mig-analytic_partner branch from 91ba837 to 80160cb Compare July 24, 2024 15:17
DorianMAG
DorianMAG approved these changes Jul 25, 2024
View reviewed changes
Copy link

@DorianMAG DorianMAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review
Seems to be good
Thx for this work

JulienMartinez
JulienMartinez approved these changes Jul 29, 2024
View reviewed changes
Copy link

@JulienMartinez JulienMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review
LTGM

@peluko00
Copy link
Contributor

Hi @gaelTorrecillas, where is the pre-commit commit before migration commit?

@flotho
Copy link
Member

flotho commented Aug 17, 2024

Hi @gaelTorrecillas, where is the pre-commit commit before migration commit?

Holidays for @gaelTorrecillas more to come in a few weeks

@maisim maisim mentioned this pull request Aug 26, 2024
Closed
@rafaelbn
Copy link
Member

/ocabot migration analytic_partner

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Aug 26, 2024
@OCA-git-bot
Copy link
Contributor

The migration issue (#489) has not been updated to reference the current pull request because a previous pull request (#609) is not closed.
Perhaps you should check that there is no duplicate work.
CC @dreispt

@dreispt
Copy link
Member

dreispt commented Aug 30, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-672-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8fc304f into OCA:16.0 Aug 30, 2024
8 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3bd2cb6. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peluko00 peluko00 peluko00 requested changes

@dreispt dreispt dreispt approved these changes

@JulienMartinez JulienMartinez JulienMartinez approved these changes

@DorianMAG DorianMAG DorianMAG approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.