[17.0][OU-ADD] account: Migration to 17.0 #4668
Conversation
|
/ocabot migration account |
|
tests are fixed in #4669, which also actually makes the files from the test folder run |
|
/ocabot rebase |
hbrunn
force-pushed
the
17.0-account
branch
3 times, most recently
from
d16d0b3 to
2e69b80
Compare
There was a problem hiding this comment.
I tested it, and it's working fine. This PR is blocking several others. Could it be prioritized? @pedrobaeza
| def convert_from_company_dependent( | ||
| env, | ||
| model_name, | ||
| origin_field_name, | ||
| destination_field_name, | ||
| origin_id_column_name, | ||
| model_table_name=None, | ||
| ): | ||
| """ | ||
| Move a company-dependent field back to the model table. |
There was a problem hiding this comment.
I think it could be useful to move this function to openupgradelib to improve reusability. It could serve as a base utility for scenarios requiring the conversion of property fields to JSON during migrations to version 18.
There was a problem hiding this comment.
that's a very different logic, you'll find the v18 function here
By now I've seen most of the migrations for v17 and didn't see another module where the case we have in the account module happens.
|
This PR has the |
openupgrade_scripts/scripts/account/17.0.1.2/upgrade_analysis_work.txt
Outdated
Show resolved
Hide resolved
|
thanks @MiquelRForgeFlow for the review |
|
I squashed what I could without co-opting other people's work |
|
Test failed :S |
|
rerunning them helped |
continuation of #4662
I tested this with my own DB, a few customers', and the demo database and couldn't find issues any more, so from my side I think it's done.