Implement stream pooling and more fine grained lock #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using multiple threads to call
GetFile<T>
, the lock was being held perSqPack
, which effectively is a.dat
file. Changed that to lock per file inside a.dat
file, and addedSqPackStreamPool? GameData.StreamPool
which will reuse already opened file handles to avoid performance hit from creating handle per every file accessed.The attached test code iterates 800,054 paths from
040000
. The test was done on 16 P-threads on 13900k.SqPackStreamPool_TestCode.txt
SqPackStreamPool_TestResult.txt
Notes
Microsoft.Extensions.ObjectPool
has been added as a dependency.GameData
is now implementsIDisposable
, so that it disposesInstanceOfGameData.StreamPool
along with it.SqPack.FileCache
andSqPack.CacheLock
are now obsolete, and they do nothing.