Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #26265: Pop up validation for restoring archive #6167

Conversation

clarktsiory
Copy link
Contributor

@clarktsiory clarktsiory commented Feb 7, 2025

https://issues.rudder.io/issues/26265

Since we have a modal which is outside of the <form>, we need a reference to the form in the confirm button : https://stackoverflow.com/a/6644180

@clarktsiory clarktsiory requested a review from fanf February 7, 2025 08:27
Copy link
Member

@fanf fanf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/6167
-- Your faithful QA
Kant merge: "Science is organized knowledge. Wisdom is organized life."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/96688/console)

@clarktsiory
Copy link
Contributor Author

OK, merging this PR

@clarktsiory clarktsiory merged commit ce0c9f4 into Normation:branches/rudder/8.1 Feb 7, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants