Fixes #26322: When several plugins are using the same menu, only the last one is displayed #6165
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
requested changes
Feb 7, 2025
There was a problem hiding this comment.
OK, so the problem I used to have is that if the plugin is not make at least one time, it's not found in the map of plugins because the plugin ID is not present in the build metadata file. But we don't need late checking.
Can you please remove the comment above the change ? It tells the opposite of what is done.
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_26322/when_several_plugins_are_using_the_same_menu_only_the_last_one_is_displayed
branch
from
ac1d398 to
5c3a22f
Compare
fanf
approved these changes
Feb 7, 2025
…last one is displayed
fanf
force-pushed
the
bug_26322/when_several_plugins_are_using_the_same_menu_only_the_last_one_is_displayed
branch
from
5c3a22f to
e0df649
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/26322
If two plugins are setting the same menu, data that were already set are replaced because we are resetting the menu with the one from the new plugin