Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate/use dropdown helpers from shared #91

Merged
merged 6 commits into from
Oct 21, 2024

Conversation

tsvetelinpetrov
Copy link
Contributor

No description provided.

Copy link

Add labels:

  • 'doc required' or 'doc not required'
  • 'ui required' or 'ui not required'

For UI review:

  • describe the changes
  • add pictures
  • add the relevant UI responsible(s) as a reviewer

@tsvetelinpetrov tsvetelinpetrov added doc not required All PRs either need "doc required" or "doc not required". ui not required All PRs either need "ui required" or "ui not required". labels Oct 18, 2024
Copy link
Contributor

@kylebonnici kylebonnici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment to the change log otherwise you can merge :)

Changelog.md Outdated
@@ -3,6 +3,7 @@
### Changed

- Updated `nrfutil device` to v2.6.4.
- Extracted dataConstrutors to dropdown helper in shared.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is not a customer facing change we do not need to put it in the change log

@tsvetelinpetrov tsvetelinpetrov merged commit cb51404 into main Oct 21, 2024
3 checks passed
@tsvetelinpetrov tsvetelinpetrov deleted the renovate/use-dropdown-helpers-from-shared branch October 21, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc not required All PRs either need "doc required" or "doc not required". ui not required All PRs either need "ui required" or "ui not required".
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants