Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: upgrade upload/download artifacts to v4 #782

Merged
merged 2 commits into from
Jan 30, 2025
Merged

ci: upgrade upload/download artifacts to v4 #782

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7de9e6a
ci: upgrade upload/download artifacts to v4
agostbiro Jan 30, 2025
be88de5
Update .github/workflows/edr-npm-release.yml
agostbiro Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .github/workflows/edr-npm-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,12 +144,13 @@ jobs:
if: ${{ !matrix.settings.docker }}
shell: bash
- name: Upload artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: bindings-${{ matrix.settings.target }}
# The upload artifact action doesn't respect the working directory setting. Unclear if this is a bug or not
# https://github.com/actions/upload-artifact/issues/294
path: ./crates/edr_napi/${{ env.APP_NAME }}.*.node
overwrite: true
agostbiro marked this conversation as resolved.
Show resolved Hide resolved
if-no-files-found: error
test-macOS-windows-binding:
name: Test bindings on ${{ matrix.settings.target }} - node@${{ matrix.node }}
Expand Down Expand Up @@ -178,7 +179,7 @@ jobs:
- name: Install dependencies
run: pnpm install --frozen-lockfile --prefer-offline
- name: Download artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: bindings-${{ matrix.settings.target }}
path: ./crates/edr_napi/
Expand All @@ -204,7 +205,7 @@ jobs:
- name: Install dependencies
run: pnpm install --frozen-lockfile --prefer-offline
- name: Download artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: bindings-x86_64-unknown-linux-gnu
path: ./crates/edr_napi/
Expand Down Expand Up @@ -236,7 +237,7 @@ jobs:
pnpm config set supportedArchitectures.libc "musl"
pnpm install --frozen-lockfile --prefer-offline
- name: Download artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: bindings-x86_64-unknown-linux-musl
path: ./crates/edr_napi/
Expand All @@ -262,7 +263,7 @@ jobs:
with:
version: 9
- name: Download artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: bindings-aarch64-unknown-linux-gnu
path: ./crates/edr_napi/
Expand Down Expand Up @@ -306,7 +307,7 @@ jobs:
with:
version: 9
- name: Download artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: bindings-aarch64-unknown-linux-musl
path: ./crates/edr_napi/
Expand Down Expand Up @@ -377,7 +378,7 @@ jobs:
- name: Install dependencies
run: pnpm install --frozen-lockfile --prefer-offline
- name: Download all artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
path: ./crates/edr_napi/artifacts
- name: Check number of artifacts
Expand Down
Loading