Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump seaport and uniswap benchmark samples #779

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

agostbiro
Copy link
Member

We've improved a lot on the seaport and uniswap benchmark scenarios which causes variability resulting in false positive regression alerts. The variability is observable visually at: https://nomic-foundation-automation.github.io/edr-benchmark-results/bench/

This is a quick fix for the variability by bumping the number of iterations for these scenarios. A proper fix would be using a more robust statistic for the results, but this takes some time to test.

@agostbiro agostbiro self-assigned this Jan 28, 2025
Copy link

changeset-bot bot commented Jan 28, 2025

⚠️ No Changeset found

Latest commit: 06daf8b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@agostbiro agostbiro temporarily deployed to github-action-benchmark January 28, 2025 09:39 — with GitHub Actions Inactive
@agostbiro agostbiro requested a review from a team January 28, 2025 09:39
@agostbiro agostbiro added the no changeset needed This PR doesn't require a changeset label Jan 28, 2025
@agostbiro agostbiro added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 7f1847c Jan 29, 2025
38 checks passed
@agostbiro agostbiro deleted the ci/bump-iterations branch January 29, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changeset needed This PR doesn't require a changeset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants