Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lure #269

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Lure #269

wants to merge 5 commits into from

Conversation

ZeChrales
Copy link
Contributor

display pokestops lured on web map

db changes & new pokestops query

Copy link
Contributor

@evenly-epic-mule evenly-epic-mule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work! 👍

could you maybe still add a sql file for adding the column, as I think it is not updated / added by monocle it self

'<br>=&gt; <a href=https://www.google.com/maps/?daddr='+ item.lat + ','+ item.lon +' target="_blank" title="See in Google Maps">Get directions</a>');
marker.bindPopup(
'<b>Pokestop: ' + expireDate + '</b>' +
'<br>=&gt; <a href=https://www.google.com/maps/?daddr=' + item[1] + ',' + item[2] +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to have the link in qotation href="https://[...]"

@ZeChrales
Copy link
Contributor Author

yeah I had to change some things in database, I'm waiting for Noctem's merge to check the upgrade of database

@MrCanan
Copy link

MrCanan commented Jul 26, 2017

Is there any chance this PR be merged ? (since one month) =)

@cptmedic
Copy link

I agree this is actually something I would love to see. We are hosting lure parties near weekly and I feel those that are aware who use the maps would migrate over if they saw them on the map

@MrCanan
Copy link

MrCanan commented Jul 30, 2017

Exactly same as you. =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants