use MVars to implement recording of mocked requests for nri-http
#128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jali-clarke
changed the title
MVars to implement recording of mocked requestsMVars to implement recording of mocked requests for nri-http
thiagohdeplima
approved these changes
Dec 26, 2024
jali-clarke
deleted the
foxen/fxn-3673-aide-ci-flake-deployertesteffectspechs
branch
|
Hi! Why was this implemented in favor of my PR? #127 |
|
@waj this is on me - i didn't check for existing prs before starting work on this. you approach works perfectly well according to the documentation for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should hopefully remove a source of flake for test cases that involve multiple concurrent (mocked) requests
testing:
part of FXN-3673