Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wike: 3.1.0 -> 3.1.1 #378040

Merged
merged 1 commit into from
Jan 30, 2025
Merged

wike: 3.1.0 -> 3.1.1 #378040

merged 1 commit into from
Jan 30, 2025
+2 −2

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Jan 30, 2025

Diff: hugolabe/Wike@3.1.0...3.1.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@getchoo getchoo added 11.by: package-maintainer This PR was created by the maintainer of the package it changes backport release-24.11 Backport PR automatically labels Jan 30, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Jan 30, 2025
@Tert0
Copy link

Tert0 commented Jan 30, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 378040

x86_64-linux

✅ 1 package built:
  • wike

Tert0
Tert0 approved these changes Jan 30, 2025
View reviewed changes
Copy link

@Tert0 Tert0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on x86_64-linux

@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 30, 2025
@NickCao NickCao merged commit aca794b into NixOS:master Jan 30, 2025
28 of 30 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 30, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jan 30, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tert0 Tert0 Tert0 approved these changes

@NickCao NickCao NickCao approved these changes

@dawidd6 dawidd6 Awaiting requested review from dawidd6

@michaelgrahamevans michaelgrahamevans Awaiting requested review from michaelgrahamevans

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@getchoo @Tert0 @NickCao