Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pflotran: init at 6.0.1 #377999

Merged
merged 2 commits into from
Jan 30, 2025
Merged

pflotran: init at 6.0.1 #377999

merged 2 commits into from
Jan 30, 2025

Conversation

sheepforce
Copy link
Member

This adds PFLOTRAN, a simulation code for geophysics, https://www.pflotran.org/documentation/index.html

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the petsc update an extra commit.
There are also some formatting issues.

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/by-name/pf/pflotran/package.nix Show resolved Hide resolved
@sheepforce sheepforce force-pushed the pflotran branch 2 times, most recently from 1452ade to 110d557 Compare January 30, 2025 16:15
@sheepforce
Copy link
Member Author

Please make the petsc update an extra commit.

Oh I've overlooked that. Is a separate commit now.

@markuskowa
Copy link
Member

There still seems to be an issue with the formatting of the package.nix file.

@markuskowa markuskowa merged commit 74000f9 into NixOS:master Jan 30, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants