tilt: add completions #374349
Open
tilt: add completions #374349
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znd4
commented
Jan 16, 2025
| } | ||
| }).overrideAttrs | ||
| (old: { | ||
| postInstall = |
There was a problem hiding this comment.
It didn't seem like postInstall is a supported argument of buildGoModule. sorry if the way I've done this is bad form in nixpkgs
There was a problem hiding this comment.
Also, lmk if I should do the fancy stdenv.buildPlatform.canExecute thing
znd4
force-pushed
the
feat/tilt-completions
branch
from
67bd3cc to
ca1080a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added completions to tilt, and tested manually / currently using this version of the package.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.