ruff: 0.9.1 -> 0.9.2 #374335
Merged
ruff: 0.9.1 -> 0.9.2 #374335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drupol
approved these changes
Jan 16, 2025
|
|
I'm getting error trying to build ruff on $ nix build github:NixOS/nixpkgs/2599327bc48f151f3c725a4a92902561af98da73#ruff
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 4 filtered out; finished in 0.00s
Running unittests src/lib.rs (target/aarch64-apple-darwin/debug/deps/ruff_annotate_snippets-b3a6163140783f37)
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Running tests/examples.rs (target/aarch64-apple-darwin/debug/deps/examples-3fcb7328bd21c94f)
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 4 filtered out; finished in 0.00s
Running tests/fixtures/main.rs (target/aarch64-apple-darwin/debug/deps/fixtures-e8e11b634bb8a8d8)
error: unexpected argument '--skip=added_package' found
Usage: fixtures-e8e11b634bb8a8d8 [OPTIONS] [FILTER]
For more information, try '--help'.
error: test failed, to rerun pass `-p ruff_annotate_snippets --test fixtures`
Caused by:
process didn't exit successfully: `/private/tmp/nix-build-ruff-0.9.2.drv-0/source/target/aarch64-apple-darwin/debug/deps/fixtures-e8e11b634bb8a8d8 --test-threads=8 -- --test-threads=8 --skip=added_package --skip=add_search_path --skip=changed_file --skip=changed_versions_file --skip=deleted_file --skip=directory_deleted --skip=directory_moved_to_trash --skip=directory_moved_to_workspace --skip=directory_renamed --skip=hard_links_in_workspace --skip=hard_links_to_target_outside_workspace --skip=move_file_to_trash --skip=move_file_to_workspace --skip=nested_packages_delete_root --skip=new_file --skip=new_ignored_file --skip=removed_package --skip=rename_file --skip=search_path '--skip=unix::changed_metadata' '--skip=unix::symlinked_module_search_path' '--skip=unix::symlink_inside_workspace'` (exit status: 2) |
|
Some tests fail on darwin. |
13 tasks
|
I'm seeing the same error as @DontEatOreo above #374335 (comment) Setting |
|
Why was this merged so quickly? @GaetanLepage your own nixpkgs-review result shows |
This was definitely a mistake on my end. Also, we have merged the fix quite soon but not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
Changelog: https://github.com/astral-sh/ruff/releases/tag/0.9.2
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.