-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hoarder: init at 0.21.0 #374312
Open
three
wants to merge
2
commits into
NixOS:master
Choose a base branch
from
three:add-hoarder-app-pr
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
hoarder: init at 0.21.0 #374312
+228
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
8.has: maintainer-list (update)
This PR changes `maintainers/maintainer-list.nix`
label
Jan 16, 2025
NixOSInfra
added
the
12. first-time contribution
This PR is the author's first one; please be gentle!
label
Jan 16, 2025
github-actions
bot
added
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
labels
Jan 16, 2025
three
force-pushed
the
add-hoarder-app-pr
branch
from
January 16, 2025 16:17
a627195
to
0570a9b
Compare
sikmir
reviewed
Jan 16, 2025
Comment on lines
+31
to
+32
rev = "v${finalAttrs.version}"; | ||
sha256 = "sha256-3xgpiqq+BV0a/OlcQiGDt59fYNF+zP0+HPeBCRiZj48="; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
rev = "v${finalAttrs.version}"; | |
sha256 = "sha256-3xgpiqq+BV0a/OlcQiGDt59fYNF+zP0+HPeBCRiZj48="; | |
tag = "v${finalAttrs.version}"; | |
hash = "sha256-3xgpiqq+BV0a/OlcQiGDt59fYNF+zP0+HPeBCRiZj48="; |
sikmir
reviewed
Jan 16, 2025
Comment on lines
+103
to
+105
--replace "HOARDER_LIB_PATH=" "HOARDER_LIB_PATH=$HOARDER_LIB_PATH" \ | ||
--replace "RELEASE=" "RELEASE=${version}" \ | ||
--replace "NODEJS=" "NODEJS=${nodejs}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
--replace "HOARDER_LIB_PATH=" "HOARDER_LIB_PATH=$HOARDER_LIB_PATH" \ | |
--replace "RELEASE=" "RELEASE=${version}" \ | |
--replace "NODEJS=" "NODEJS=${nodejs}" | |
--replace-warn "HOARDER_LIB_PATH=" "HOARDER_LIB_PATH=$HOARDER_LIB_PATH" \ | |
--replace-warn "RELEASE=" "RELEASE=${version}" \ | |
--replace-warn "NODEJS=" "NODEJS=${nodejs}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
8.has: maintainer-list (update)
This PR changes `maintainers/maintainer-list.nix`
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
12. first-time contribution
This PR is the author's first one; please be gentle!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)This PR packages the Hoarder bookmarking app (homepage: https://hoarder.app/) and resolves #359226.
Project Homepage: https://hoarder.app/
Project v0.21.0 Release: https://github.com/hoarder-app/hoarder/releases/tag/v0.21.0
This package is the sum of multiple related components:
I am not affiliated with the upstream project.
Basic server test script
Script to test basic server functionality after running
nix build .#hoarder
. This isn't as full-featured as the NixOS configuration below.Example NixOS configuration and video demonstrating basic functionality
This example config demonstrates how this package might be used,
This configuration supports the following features,
Here is a video demonstrating this functionality,
Screen.Recording.2025-01-16.at.8.25.38.AM.mov
Known Cache Issue
Caching does not seem to work properly. The following types of errors get regularly logged during normal usage,
I don't believe this is possible to fix without changing the upstream project. This does not seem to effect functionality.
Add a 👍 reaction to pull requests you find important.