Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitwatch package - possible lacking of gnugrep and gnused dependencies #374287

Conversation

roomcays
Copy link

As I have described on discourse thread:

  1. I have installed this packages system-wide on NixOS stable 24.11
  2. when using gitwatch program from interactive shell it worked fine
  3. I have then tried to put in under control of user-spaced systemd service unit to make it start automatically; this however could not happen due to errors:
Dec 31 22:34:50 hosthost gitwatch[3688627]: /nix/store/vabiazsm1vk3mcjhfx7cq31p211icx7s-gitwatch/bin/.gitwatch-wrapped: line 225: sed: command not found
Dec 31 22:34:50 hosthost gitwatch[3688629]: /nix/store/vabiazsm1vk3mcjhfx7cq31p211icx7s-gitwatch/bin/.gitwatch-wrapped: line 273: grep: command not found

Things done

I have blindly added gnused and gnugrep to the package.nix script, but I have not tested it because I don't know how to do it in the "easy way" (I have tried cloning the nixpkgs repo though, but I have failed upon system update).

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 16, 2025
@nix-owners
Copy link

nix-owners bot commented Jan 16, 2025

The PR's base branch is set to master, but 3798 commits from the release-24.11 branch are included. Make sure you know the right base branch for your changes, then:

  • If the changes should go to the release-24.11 branch, change the base branch to release-24.11
  • If the changes should go to the master branch, rebase your PR onto the merge base with the master branch:
    # git rebase --onto $(git merge-base upstream/master HEAD) $(git merge-base upstream/release-24.11 HEAD)
    git rebase --onto 1d95cb5fa7a38717172e090d54338ca8daef8a86 edf04b75c13c2ac0e54df5ec5c543e300f76f1c9
    git push --force-with-lease

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/i-think-i-found-a-bug-in-gitwatch-package-but-i-dont-know-how-to-verify-and-possibly-fix-it/58167/3

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jan 16, 2025
@github-actions github-actions bot added 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: qt/kde 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: printing 6.topic: rust 6.topic: policy discussion 6.topic: vim 6.topic: xfce The Xfce Desktop Environment 6.topic: hardware 6.topic: nixos-container Imperative and declarative systemd-nspawn containers 6.topic: pantheon The Pantheon desktop environment 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: testing Tooling for automated testing of packages and modules 6.topic: cinnamon Desktop environment 6.topic: module system About "NixOS" module system internals 6.topic: jitsi 6.topic: systemd and removed 2.status: merge conflict This PR has merge conflicts with the target branch 12. first-time contribution This PR is the author's first one; please be gentle! labels Jan 16, 2025
@github-actions github-actions bot removed 6.topic: vim 6.topic: xfce The Xfce Desktop Environment 6.topic: hardware 6.topic: nixos-container Imperative and declarative systemd-nspawn containers 6.topic: pantheon The Pantheon desktop environment 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: testing Tooling for automated testing of packages and modules 6.topic: cinnamon Desktop environment 6.topic: module system About "NixOS" module system internals 6.topic: jitsi 6.topic: systemd 6.topic: agda "A dependently typed programming language / interactive theorem prover" 6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: Lumina DE The Lumina Desktop Environment 6.topic: Enlightenment DE The Enlightenment Desktop Environment 6.topic: mate The MATE Desktop Environment 6.topic: flakes The experimental Nix feature 6.topic: lib The Nixpkgs function library 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: php 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: k3s Kubernates distribution (https://k3s.io/) 6.topic: deepin Desktop environment and its components 6.topic: dotnet Language: .NET 6.topic: nvidia 6.topic: xen-project The Xen Project hypervisor 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions labels Jan 16, 2025
@aucub
Copy link
Contributor

aucub commented Jan 16, 2025

Please base on the master branch. After the PR is merged, the bot can create the PR of backport 24.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants