dotnet: january 2025 releases #374284
Open
dotnet: january 2025 releases #374284
+1,133
−1,210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdout was being lost, but it could contain important information about failures.
This stops incorrect paths from being used when run in a temporary worktree by maintainers/scripts/update.nix.
|
corngood
commented
Jan 16, 2025
| @@ -77,7 +78,9 @@ async def run_update_script(nixpkgs_root: str, merge_lock: asyncio.Lock, temp_di | |||
| eprint(f"--- SHOWING ERROR LOG FOR {package['name']} ----------------------") | |||
| eprint() | |||
| eprint(e.stderr.decode('utf-8')) | |||
| with open(f"{package['pname']}.log", 'wb') as logfile: | |||
| with open(f"{package['pname']}.out.log", 'wb') as logfile: | |||
There was a problem hiding this comment.
@jtojnar would you mind taking a look at this commit? It was useful for me to debug dotnet stuff which often writes to stdout.
I had originally omitted the .log extension, but it's in .gitignore, so I decided to keep it.
I think ideally this would write both streams to a single temporary log file, but that's likely a bigger change. I can drop this commit if anyone has any concerns.
GGG-KILLER
approved these changes
Jan 16, 2025
GGG-KILLER
approved these changes
Jan 16, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes some problems I found with the update scripts.
Cc: @NixOS/dotnet
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.