Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

harper: 0.15.0 -> 0.16.0 #374164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

harper: 0.15.0 -> 0.16.0 #374164

wants to merge 1 commit into from
+6 −6

Conversation

pbsds
Copy link
Member

@pbsds pbsds commented Jan 15, 2025 •
edited
Loading

Diff: Automattic/harper@v0.15.0...v0.16.0

Changelog: https://github.com/elijah-potter/harper/releases/tag/v0.16.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pbsds pbsds marked this pull request as ready for review January 15, 2025 23:14
sumnerevans
sumnerevans reviewed Jan 16, 2025
View reviewed changes
pkgs/by-name/ha/harper/package.nix Outdated
@@ -6,16 +6,16 @@

rustPlatform.buildRustPackage rec {
pname = "harper";
version = "0.15.0";
version = "0.16.0";

src = fetchFromGitHub {
owner = "elijah-potter";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably change the owner and meta to point at the new repository (Elijah moved the repo under the Automattic organization)

@pbsds pbsds force-pushed the bump-harper-1736980892 branch from 348e23e to c0d94a3 Compare January 16, 2025 12:38
sumnerevans
sumnerevans approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@sumnerevans sumnerevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 374164

x86_64-linux

✅ 1 package built:
  • harper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumnerevans sumnerevans sumnerevans approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbsds @sumnerevans