Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.netbox-interface-synchronization: init at 4.1.4 #374138

Merged

Conversation

felbinger
Copy link
Member

@felbinger felbinger commented Jan 15, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream lists attrs as a dependency, but it doesn't seem to actually be used so it's probably fine

Diff LGTM

@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 15, 2025
@felbinger felbinger force-pushed the netbox-interface-sync-plugin branch from 96b9fa9 to 975ff52 Compare January 16, 2025 17:08
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 16, 2025
@felbinger
Copy link
Member Author

felbinger commented Jan 16, 2025

Upstream lists attrs as a dependency, but it doesn't seem to actually be used so it's probably fine

It works without attrs... I created NetTech2001/netbox-interface-synchronization#12 to find out, if there is a broken feature I couldn't find yet...

@felbinger felbinger force-pushed the netbox-interface-sync-plugin branch from 975ff52 to 494c5c2 Compare January 16, 2025 17:35
@felbinger felbinger force-pushed the netbox-interface-sync-plugin branch from 494c5c2 to 03bab65 Compare January 17, 2025 10:49
@SuperSandro2000 SuperSandro2000 merged commit 8ad4497 into NixOS:master Jan 17, 2025
25 of 27 checks passed
@felbinger felbinger added the backport release-24.11 Backport PR automatically label Jan 17, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 17, 2025

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants