Fixes and housekeeping for the varnish module #373747
Open
+69
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
ctheune
force-pushed
the
varnish-multiple-fixes
branch
2 times, most recently
from
036f34c to
6013d9a
Compare
ctheune
force-pushed
the
varnish-multiple-fixes
branch
from
6013d9a to
82b020e
Compare
|
Can you please remove the |
ctheune
force-pushed
the
varnish-multiple-fixes
branch
from
82b020e to
0640622
Compare
Of course - better now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The varnish module is semi-broken at the moment. Our last changes weren't properly covered by
tests and using
varnishadmdidn't work afterwards.I've fixed this, added test and did a bit of house keeping. Our team is available to maintain this in the
future, so I've marked us as maintainers.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.