Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pretix.plugins.mollie: init at 2.2.1 #372772

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Conversation

arjan-s
Copy link
Contributor

@arjan-s arjan-s commented Jan 10, 2025

This PR adds the official Mollie plugin to the Pretix package.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from mweinelt January 10, 2025 22:48
@arjan-s arjan-s changed the title pretix: add official mollie plugin pretix.plugins.mollie: init at 2.2.1 Jan 10, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 10, 2025
pkgs/by-name/pr/pretix/plugins/mollie.nix Outdated Show resolved Hide resolved
pkgs/by-name/pr/pretix/plugins/mollie.nix Outdated Show resolved Hide resolved
@arjan-s
Copy link
Contributor Author

arjan-s commented Jan 10, 2025

@Defelo thanks for the swift review! I updated the commit with the changes you suggested.

Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks good.

@mweinelt mweinelt merged commit b200f5b into NixOS:master Jan 11, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants