-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readest: init at 0.9.7 #372249
readest: init at 0.9.7 #372249
Conversation
d213d60
to
fa0c590
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5082 |
0c27c1b
to
0cbadf5
Compare
When trying to run the binary I get this error:
Does it work for you? |
My bad, the
According to tauri-apps/tauri#9304, it's an nvidia issue, and a workaround for it is setting the environment variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the binary by opening a pdf file in it, update script works, code LGTM
nixpkgs-review
result
Generated using nixpkgs-review
.
Command: nixpkgs-review pr 372249
x86_64-linux
✅ 1 package built:
- readest
c4bdab2
to
308e60a
Compare
Build fails: readest> Running beforeBuildCommand `pnpm build`
readest> ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL Command "build" not found
readest> Error beforeBuildCommand `pnpm build` failed with exit code 254 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds again and tested binary, changes look good
nixpkgs-review
result
Generated using nixpkgs-review
.
Command: nixpkgs-review pr 372249
x86_64-linux
✅ 1 package built:
- readest
Readest is a modern, feature-rich ebook reader designed for avid readers offering seamless cross-platform access, powerful tools, and an intuitive interface to elevate your reading experience. https://github.com/readest/readest
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.