Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readest: init at 0.9.7 #372249

Closed
wants to merge 1 commit into from
Closed

readest: init at 0.9.7 #372249

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 9, 2025

Readest is a modern, feature-rich ebook reader designed for avid readers offering seamless cross-platform access, powerful tools, and an intuitive interface to elevate your reading experience. https://github.com/readest/readest

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 9, 2025
@ghost ghost changed the title readest: init at 0.9.1 readest: init at 0.9.2 Jan 10, 2025
@ghost ghost changed the title readest: init at 0.9.2 readest: init at 0.9.3 Jan 11, 2025
@ghost ghost force-pushed the readest branch 2 times, most recently from d213d60 to fa0c590 Compare January 12, 2025 20:15
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5082

@ghost ghost force-pushed the readest branch 2 times, most recently from 0c27c1b to 0cbadf5 Compare January 15, 2025 17:11
@ghost ghost changed the title readest: init at 0.9.3 readest: init at 0.9.5 Jan 15, 2025
@gepbird
Copy link
Contributor

gepbird commented Jan 15, 2025

When trying to run the binary I get this error:

Failed to initialize gtk backend!: BoolError { message: "Failed to initialize GTK", filename: "/build/readest-0.9.5-vendor.tar.gz/gtk/src/rt.rs", function: "gtk::rt::init", line: 141 }

Does it work for you?

@gepbird
Copy link
Contributor

gepbird commented Jan 15, 2025

Failed to initialize gtk backend!: BoolError { message: "Failed to initialize GTK", filename: "/build/readest-0.9.5-vendor.tar.gz/gtk/src/rt.rs", function: "gtk::rt::init", line: 141 }

My bad, the DISPLAY variable was unset, as I started readest from a tmux pane that I created via ssh. Now the GUI opens but it doesn't render and I see the following error many times:

AcceleratedSurfaceDMABuf was unable to construct a complete framebuffer

According to tauri-apps/tauri#9304, it's an nvidia issue, and a workaround for it is setting the environment variable WEBKIT_DISABLE_DMABUF_RENDERER. In nixpkgs there are 2 instances of this variable so potentially other people can run into this when trying to use readest. I suggest setting it for this package, for reference: https://github.com/NixOS/nixpkgs/blob/b3aa86e4626d2d38eb857766a62e7bac78636fd5/pkgs/by-name/ci/cinny-desktop/package.nix

Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the binary by opening a pdf file in it, update script works, code LGTM

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372249


x86_64-linux

✅ 1 package built:
  • readest

pkgs/by-name/re/readest/package.nix Outdated Show resolved Hide resolved
@ghost ghost marked this pull request as draft January 16, 2025 18:42
@ghost ghost marked this pull request as ready for review January 16, 2025 19:45
@ghost ghost changed the title readest: init at 0.9.5 readest: init at 0.9.6 Jan 18, 2025
@ghost ghost force-pushed the readest branch 2 times, most recently from c4bdab2 to 308e60a Compare January 23, 2025 22:09
@ghost ghost changed the title readest: init at 0.9.6 readest: init at 0.9.7 Jan 23, 2025
@gepbird
Copy link
Contributor

gepbird commented Jan 23, 2025

Build fails:

readest>     Running beforeBuildCommand `pnpm build`
readest>  ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL  Command "build" not found
readest>     Error beforeBuildCommand `pnpm build` failed with exit code 254

Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds again and tested binary, changes look good

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372249


x86_64-linux

✅ 1 package built:
  • readest

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 25, 2025
@ghost ghost marked this pull request as draft January 25, 2025 22:23
@ghost ghost closed this by deleting the head repository Jan 26, 2025
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants