Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyfa: add desktop-item #371912

Merged
merged 1 commit into from
Jan 8, 2025
Merged

pyfa: add desktop-item #371912

merged 1 commit into from
Jan 8, 2025
+20 −0

Conversation

Daholli
Copy link
Contributor

@Daholli Daholli commented Jan 7, 2025 •
edited
Loading

Add a desktop item to pyfa so non rofi users can also open it without need for the terminal

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Daholli
pyfa: add desktop-item
59d9636 
put copydesktopItems in the right spot and add icon to required path

make sure copyDesktopItems actually runs
@Daholli Daholli requested a review from paschoal January 7, 2025 20:29
@Daholli
Copy link
Contributor Author

Daholli commented Jan 7, 2025

closes #371185

@Daholli Daholli requested a review from ToasterUwU January 7, 2025 20:29
@Daholli Daholli added the 0.kind: enhancement Add something new label Jan 7, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 7, 2025
@ToasterUwU
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371912

x86_64-linux

✅ 1 package built:
  • pyfa

@ToasterUwU
Copy link
Member

@Daholli @paschoal Btw, if you ever need to test a single package like this by actually installing it, you can checkout the branch of the PR, and than just run nix profile install .#package-name-here to install it, just dont forget to uninstall it after as well.

Easier than making a overlay and testing it like that.

ToasterUwU
ToasterUwU approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@ToasterUwU ToasterUwU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Desktop file seems to work nicely, it shows up in the KDE search thing with description and everything. Opening it via that desktop file also works nicely.

Thanks for working on this so quickly, didnt even get a chance to do it myself lol

@Daholli
Copy link
Contributor Author

Daholli commented Jan 8, 2025

Yeah I also figured out that I can just check if the desktop file is actually being generated in out/share/applications that this is already enough indication.

Also my system was already setup to checkout one of my branches anyways so I just changed the ref and factorio to pyfa and everything was running :D

@paschoal
Copy link
Contributor

paschoal commented Jan 8, 2025

looks good to me! using rofi with drun option now has a pyfa with a nice little icon!

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 8, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2186

@jopejoe1 jopejoe1 merged commit ee4593f into NixOS:master Jan 8, 2025
49 of 53 checks passed
@Daholli Daholli deleted the pyfa-desktopItem branch January 8, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToasterUwU ToasterUwU ToasterUwU approved these changes

@paschoal paschoal paschoal approved these changes

Assignees
No one assigned
Labels
0.kind: enhancement Add something new 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Daholli @ToasterUwU @paschoal @nixos-discourse @wegank @jopejoe1