Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging-next] arrow-cpp: 18.0.0 -> 18.1.0; add boost 187 patch #371824

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

paparodeo
Copy link
Contributor

@paparodeo paparodeo commented Jan 7, 2025

https://github.com/apache/arrow/releases/tag/apache-arrow-18.1.0
apache/arrow#45057
https://hydra.nixos.org/build/284701371

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@FliegendeWurst
Copy link
Member

For reference, the error is

FAILED: src/arrow/CMakeFiles/arrow_testing_objlib.dir/testing/process.cc.o
/nix/store/cfncx7a496zhh9f98qdzidq3shzl1an9-gcc-wrapper-14-20241116/bin/g++ -DARROW_EXTRA_ERROR_CONTEXT -DARROW_HAVE_RUNTIME_AVX2 -DARROW_HAVE_RUNTIME_AVX512 -DARROW_HAVE_RUNTIME_BMI2 -DARROW_HAVE_RUNTIME_SSE4_2 -DARROW_HAVE_SSE4_2 -DAR>
/build/source/cpp/src/arrow/testing/process.cc:88:18: error: 'BOOST_PROCESS_V2_ASIO_NAMESPACE' is not a namespace-name
   88 | namespace asio = BOOST_PROCESS_V2_ASIO_NAMESPACE;
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/build/source/cpp/src/arrow/testing/process.cc:246:3: error: 'asio' does not name a type
  246 |   asio::io_context ctx_;
      |   ^~~~
/build/source/cpp/src/arrow/testing/process.cc: In member function 'arrow::Status arrow::util::Process::Impl::ExecuteV2()':
/build/source/cpp/src/arrow/testing/process.cc:296:30: error: 'ctx_' was not declared in this scope
  296 |         new process::process(ctx_, executable_, args_, env,
      |                              ^~~~

Still building this version, no errors yet.

@FliegendeWurst FliegendeWurst merged commit e0b6c77 into NixOS:staging-next Jan 7, 2025
30 of 34 checks passed
@paparodeo paparodeo deleted the arrow-cpp-boost branch January 7, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants