Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foundry: init at 0.3.0 #371439

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Jan 6, 2025

Foundry is a portable, modular toolkit for Ethereum application development written in Rust.

An update-svm-lists.sh script is included as a helper for myself / other maintainers to periodically update the solidity binary lists required by the svm-rs crate.

Re-spin of #284414 at a stable version and with some updates.

Closes #239614
Supersedes #284414

TODO: Test on x86_64-darwin

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

pkgs/by-name/fo/foundry/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fo/foundry/package.nix Outdated Show resolved Hide resolved
@msanft msanft force-pushed the msanft/foundry-init branch 2 times, most recently from f53bb59 to 45111cf Compare January 6, 2025 17:16
pkgs/by-name/fo/foundry/package.nix Show resolved Hide resolved
pkgs/by-name/fo/foundry/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fo/foundry/package.nix Outdated Show resolved Hide resolved
@msanft msanft force-pushed the msanft/foundry-init branch from 45111cf to 60652f2 Compare January 6, 2025 17:18
@msanft msanft requested a review from GaetanLepage January 6, 2025 17:19
Foundry is a portable, modular toolkit for Ethereum application
development written in Rust.

An `update-svm-lists.sh` script is included as a helper for myself /
other maintainers to periodically update the solidity binary lists
required by the `svm-rs` crate.

Co-authored-by: mitchmindtree <[email protected]>
@msanft msanft force-pushed the msanft/foundry-init branch from 60652f2 to 074830a Compare January 6, 2025 17:40
@msanft
Copy link
Contributor Author

msanft commented Jan 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371439


aarch64-darwin

✅ 1 package built:
  • foundry

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371439


x86_64-linux

✅ 1 package built:
  • foundry

aarch64-linux

✅ 1 package built:
  • foundry

x86_64-darwin

✅ 1 package built:
  • foundry

aarch64-darwin

✅ 1 package built:
  • foundry

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GaetanLepage GaetanLepage requested a review from drupol January 6, 2025 22:59
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 6, 2025
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Jan 7, 2025
@GaetanLepage GaetanLepage merged commit 83cb576 into NixOS:master Jan 7, 2025
25 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: foundry
5 participants