Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smap: init at 0.1.12 #371402

Merged
merged 2 commits into from
Jan 7, 2025
Merged

smap: init at 0.1.12 #371402

merged 2 commits into from
Jan 7, 2025

Conversation

yechielw
Copy link
Contributor

@yechielw yechielw commented Jan 6, 2025

Smap, passive Nmap like scanner built with shodan.io
written in go
New PR after messing up #371146

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Related #81418

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jan 6, 2025
@yechielw yechielw mentioned this pull request Jan 6, 2025
13 tasks
@yechielw
Copy link
Contributor Author

yechielw commented Jan 6, 2025

@fabaff @Defelo @lucasew I messed-up the original PR, can you review the new one here?
Sorry for being a newbie...

@lucasew
Copy link
Contributor

lucasew commented Jan 6, 2025

Diff LGTM, running nixpkgs-review to build it.

@lucasew
Copy link
Contributor

lucasew commented Jan 6, 2025

Also, please rename the second commit and the PR as explained in CONTRIBUTING.

@fabaff
Copy link
Member

fabaff commented Jan 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371402


x86_64-linux

✅ 1 package built:
  • smap

Copy link
Member

@Defelo Defelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the pull request title to smap: init at 0.1.12. Also, the first commit message should be maintainers: add yechielw

maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
@yechielw yechielw changed the title Smap init smap: init at 0.1.12 Jan 6, 2025
Smap is a drop-in replacement for Nmap powered by shodan.io written in
go
@yechielw
Copy link
Contributor Author

yechielw commented Jan 6, 2025

Done

@Defelo
Copy link
Member

Defelo commented Jan 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371402


x86_64-linux

✅ 1 package built:
  • smap

aarch64-linux

✅ 1 package built:
  • smap

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 6, 2025
@lucasew
Copy link
Contributor

lucasew commented Jan 7, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371402


x86_64-linux

✅ 1 package built:
  • smap

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@fabaff fabaff merged commit b4047da into NixOS:master Jan 7, 2025
33 of 37 checks passed
@yechielw
Copy link
Contributor Author

yechielw commented Jan 7, 2025

This was my first package commited to nix. Thanks to everyone for the help and patience...

@yechielw yechielw deleted the smap-init branch January 7, 2025 21:46
@yechielw yechielw restored the smap-init branch January 7, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants