-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
smap: init at 0.1.12 #371402
smap: init at 0.1.12 #371402
Conversation
Diff LGTM, running nixpkgs-review to build it. |
Also, please rename the second commit and the PR as explained in CONTRIBUTING. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the pull request title to smap: init at 0.1.12
. Also, the first commit message should be maintainers: add yechielw
Smap is a drop-in replacement for Nmap powered by shodan.io written in go
Done |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
This was my first package commited to nix. Thanks to everyone for the help and patience... |
Smap, passive Nmap like scanner built with shodan.io
written in go
New PR after messing up #371146
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.
Related #81418