Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redlib: 0.35.1-unstable-2024-09-22 -> 0.35.1-unstable-2024-11-01 #354406

Merged

Conversation

Guanran928
Copy link
Contributor

Redlib currectly returns error on request, see redlib-org/redlib#301

Diff: redlib-org/redlib@d5f137c...f03bdcf

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@kirillrdy
Copy link
Member

commit message and PR title should be

0.35.1-unstable-2024-09-22 -> 0.35.1-unstable-2024-11-01

@Guanran928 Guanran928 force-pushed the redlib/0.35.1-unstable-2024-11-01 branch from a8617ef to d3f1862 Compare November 8, 2024 14:58
@Guanran928 Guanran928 changed the title redlib: 0.35.1 -> 0.35.1-unstable-2024-11-01 redlib: 0.35.1-unstable-2024-09-22 -> 0.35.1-unstable-2024-11-01 Nov 8, 2024
Copy link
Contributor

@soispha soispha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofborg ofborg bot requested a review from soispha November 8, 2024 18:21
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Nov 8, 2024
@kirillrdy kirillrdy merged commit 41b1825 into NixOS:master Nov 13, 2024
34 of 35 checks passed
@Guanran928 Guanran928 deleted the redlib/0.35.1-unstable-2024-11-01 branch November 13, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants