Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redlib: 0.35.1 -> 0.35.1-unstable-2024-09-22 #343649

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

Guanran928
Copy link
Contributor

Description of changes

redlib-org/redlib#229

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Sep 24, 2024

Result of nixpkgs-review pr 343649 run on x86_64-linux 1

1 package built:
  • redlib

Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good: the package builds and the test passed.

@rnhmjoj rnhmjoj merged commit 12c8f1b into NixOS:master Sep 24, 2024
28 of 30 checks passed
@Guanran928 Guanran928 deleted the redlib/0.35.1-unstable-2024-09-22 branch October 20, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants