Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forgejo-cli: init at 0.1.1 #333198

Merged
merged 1 commit into from
Aug 13, 2024
Merged

forgejo-cli: init at 0.1.1 #333198

merged 1 commit into from
Aug 13, 2024

Conversation

isabelroses
Copy link
Member

Description of changes

Adds https://codeberg.org/Cyborus/forgejo-cli

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@isabelroses isabelroses changed the title forgejo-cli: init at 0.1.0 forgejo-cli: init at 0.1.1 Aug 11, 2024
@afh
Copy link
Member

afh commented Aug 11, 2024

Result of nixpkgs-review pr 333198 run on aarch64-darwin 1

1 package failed to build:
  • forgejo-cli

Copy link
Member

@afh afh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @isabelroses, please find below a suggestion to fix the build on darwin

pkgs/by-name/fo/forgejo-cli/package.nix Outdated Show resolved Hide resolved
@afh
Copy link
Member

afh commented Aug 11, 2024

Result of nixpkgs-review pr 333198 run on aarch64-darwin 1

1 package built:
  • forgejo-cli

Copy link
Member

@afh afh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for accepting the suggestion so swiftly, @isabelroses, much appreciated 👍

@afh afh added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Aug 11, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1898

Copy link
Member

@emilylange emilylange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright then, keep your let in :)

@isabelroses isabelroses added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Aug 11, 2024
@emilylange emilylange merged commit 02fb4b6 into NixOS:master Aug 13, 2024
28 checks passed
@isabelroses isabelroses deleted the forgejo-cli branch August 13, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants