nixops: update the PrettyTable package pin to accomodate the currently available version #281879
Conversation
…y available version
|
Did |
Yep, just checked, does render a table. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3301 |
There was a problem hiding this comment.
I tried to test your PR but I could not get it to work.
I added a new flake input nixpkgsPr = { url = github:deepfire/nixpkgs/0-gh-nixops-fix; }; and used it to get nixpkgsPr.legacyPackages.${system}.nixops_unstable in my dev shell.
Unfortunately, my dev shell did not build:
$ nix develop
warning: Git tree '/home/me/dev/mydeployments-dev' is dirty
error: builder for '/nix/store/vxphbk5v50spmw9kbw2wmmz5w0j561zj-python3.11-nixops-hetznercloud-unstable-2023-02-19.drv' failed with exit code 1;
last 10 log lines:
> * Getting build dependencies for wheel...
> * Building wheel...
> Successfully built nixops_hetznercloud-0.1.3-py3-none-any.whl
> Finished creating a wheel...
> Finished executing pypaBuildPhase
> Running phase: pythonRuntimeDepsCheckHook
> Executing pythonRuntimeDepsCheck
> Checking runtime dependencies for nixops_hetznercloud-0.1.3-py3-none-any.whl
> - hcloud==1.18.2 not satisfied by version 1.33.2
> - typing-extensions<4.0.0,>=3.7.4 not satisfied by version 4.8.0
For full logs, run 'nix log /nix/store/vxphbk5v50spmw9kbw2wmmz5w0j561zj-python3.11-nixops-hetznercloud-unstable-2023-02-19.drv'.
error: 1 dependencies of derivation '/nix/store/3w64q0ximicm8dlcbdhjyhh4l3jrgqxh-nixops-unstable-2023-12-17.drv' failed to build
error: 1 dependencies of derivation '/nix/store/cjj8akrn9lbrr8a1s3b4m0ar0s3b1fkk-mydeployment-repository-shell-env.drv' failed to build
$ nix log /nix/store/vxphbk5v50spmw9kbw2wmmz5w0j561zj-python3.11-nixops-hetznercloud-unstable-2023-02-19.drv
warning: The interpretation of store paths arguments ending in `.drv` recently changed. If this command is now failing try again with '/nix/store/vxphbk5v50spmw9kbw2wmmz5w0j561zj-python3.11-nixops-hetznercloud-unstable-2023-02-19.drv^*'
Sourcing python-remove-tests-dir-hook
Sourcing python-catch-conflicts-hook.sh
Sourcing python-remove-bin-bytecode-hook.sh
Sourcing pypa-build-hook
Using pypaBuildPhase
Sourcing python-runtime-deps-check-hook
Using pythonRuntimeDepsCheckHook
Sourcing pypa-install-hook
Using pypaInstallPhase
Sourcing python-imports-check-hook.sh
Using pythonImportsCheckPhase
Sourcing python-namespaces-hook
Sourcing python-catch-conflicts-hook.sh
@nix { "action": "setPhase", "phase": "unpackPhase" }
Running phase: unpackPhase
unpacking source archive /nix/store/yi4xv8h1dlyq7j5cffqssjih22r4kcb0-source
source root is source
setting SOURCE_DATE_EPOCH to timestamp 315619200 of file source/tests/functional/test_stop_stops.py
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "configurePhase" }
Running phase: configurePhase
no configure script, doing nothing
@nix { "action": "setPhase", "phase": "buildPhase" }
Running phase: buildPhase
Executing pypaBuildPhase
Creating a wheel...
* Getting build dependencies for wheel...
* Building wheel...
Successfully built nixops_hetznercloud-0.1.3-py3-none-any.whl
Finished creating a wheel...
Finished executing pypaBuildPhase
@nix { "action": "setPhase", "phase": "pythonRuntimeDepsCheckHook" }
Running phase: pythonRuntimeDepsCheckHook
Executing pythonRuntimeDepsCheck
Checking runtime dependencies for nixops_hetznercloud-0.1.3-py3-none-any.whl
- hcloud==1.18.2 not satisfied by version 1.33.2
- typing-extensions<4.0.0,>=3.7.4 not satisfied by version 4.8.0
|
@datafoo, there are, unfortunately, multiple problems with This is why I explicitly said:
|
|
You requested my review of this PR, how am I supposed to test it then? |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3429 |
|
Let's do it upstream. Sorry for the abysmal response time. |
Sure, makes sense, closing. |
Description of changes
This allows a plugin-less
nixops_unstableto be built onmaster. Tested with a SSH target.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.