Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmic-applets: unstable-2023-10-04 -> unstable-2023-11-13 #266653

Closed
wants to merge 1,565 commits into from

Conversation

nyabinary
Copy link
Contributor

@nyabinary nyabinary commented Nov 10, 2023

Description of changes

Active theming for cosmic-applets update
Add myself as a maintainer

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@nyabinary nyabinary marked this pull request as ready for review November 10, 2023 17:53
@ofborg ofborg bot requested a review from alyssais November 10, 2023 19:19
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 10, 2023
@nyabinary nyabinary changed the title cosmic-applets: unstable-2023-10-04 -> unstable-2023-11-09 cosmic-applets: unstable-2023-10-04 -> unstable-2023-11-13 Nov 14, 2023
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 14, 2023
@alyssais
Copy link
Member

I think your other PRs caused a merge conflict. (This is the sort of thing that moving to by-name will solve. :))

@nyabinary
Copy link
Contributor Author

I think your other PRs caused a merge conflict. (This is the sort of thing that moving to by-name will solve. :))

How do I fix that?

@alyssais
Copy link
Member

Rebase this PR.

@github-actions github-actions bot added 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: haskell 6.topic: qt/kde 6.topic: kernel The Linux kernel 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: printing 6.topic: policy discussion 6.topic: golang 6.topic: vim 6.topic: erlang 6.topic: ocaml 6.topic: xfce The Xfce Desktop Environment 6.topic: fetch 6.topic: steam Steam game store/launcher (store.steampowered.com) 6.topic: stdenv Standard environment 6.topic: nodejs 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: lua 6.topic: cinnamon Desktop environment 6.topic: systemd 6.topic: Enlightenment DE The Enlightenment Desktop Environment 6.topic: vscode 6.topic: lib The Nixpkgs function library labels Nov 14, 2023
@NixOS NixOS locked as resolved and limited conversation to collaborators Nov 14, 2023
@mweinelt
Copy link
Member

I'm locking and closing this pull request, because through the rebase you inadvertently requested many maintainers for review, which subscribed them to update notifications, resulting in unnecessary spam inside everyone's inbox. While we can remove their review requests, we sadly cannot unsubscribe anyone.

Please create a new pull request and for the next time remember to set your PR to draft status before rebasing. In draft status, you can preview the list of maintainers that are about to be requested for review, which allows you to sidestep this issue.

@mweinelt mweinelt closed this Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: cinnamon Desktop environment 6.topic: emacs Text editor 6.topic: Enlightenment DE The Enlightenment Desktop Environment 6.topic: erlang 6.topic: fetch 6.topic: golang 6.topic: haskell 6.topic: kernel The Linux kernel 6.topic: lib The Nixpkgs function library 6.topic: lua 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: nodejs 6.topic: ocaml 6.topic: policy discussion 6.topic: printing 6.topic: python 6.topic: qt/kde 6.topic: stdenv Standard environment 6.topic: steam Steam game store/launcher (store.steampowered.com) 6.topic: systemd 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: vim 6.topic: vscode 6.topic: xfce The Xfce Desktop Environment 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.