Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pterm: init at 6.0.4 #264288

Merged
merged 3 commits into from
Nov 13, 2023
Merged

pterm: init at 6.0.4 #264288

merged 3 commits into from
Nov 13, 2023

Conversation

sarcasticadmin
Copy link
Member

@sarcasticadmin sarcasticadmin commented Oct 30, 2023

Description of changes

pterm is the terminal emulator for connecting to cyber1. Cyber1 is the name for the mainframe-based CYBIS system.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

pkgs/by-name/pt/pterm/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pt/pterm/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pt/pterm/package.nix Show resolved Hide resolved
pkgs/by-name/pt/pterm/package.nix Outdated Show resolved Hide resolved
@sarcasticadmin
Copy link
Member Author

@eclairevoyant thanks for the review!

@natsukium
Copy link
Member

@ofborg eval

@pbsds
Copy link
Member

pbsds commented Nov 12, 2023

Seems the darwin build fails. Could this be patched to work under pkgsLLVM.pterm? If that still fails on ofborg then just mark it broken on darwin.

@ofborg build pkgsLLVM.pterm

@sarcasticadmin
Copy link
Member Author

sarcasticadmin commented Nov 13, 2023

@pbsds the results from ofborg failed for pkgsLLVM.pterm https://github.com/NixOS/nixpkgs/runs/18595936691

Ive marked it as broken on Darwin for the time being. Thanks for the help kicking off ofborg, I wasnt exactly sure what/how to test that.

@pbsds
Copy link
Member

pbsds commented Nov 13, 2023

Builds and runs fine, LGTM. Great work

@pbsds pbsds merged commit 96e8601 into NixOS:master Nov 13, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants