Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gforth: explicitly set lispdir #175200

Merged
merged 2 commits into from
Jun 11, 2022
Merged

Conversation

risicle
Copy link
Contributor

@risicle risicle commented May 28, 2022

Description of changes

Otherwise in situations where we don't have a working sandbox (darwin), if /usr/share/emacs happens to exist, the install
phase will try to put its lisp files there and fail due to permissions.

Fixes build on darwin.

ZHF: #172160

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

risicle added 2 commits June 11, 2022 19:13
otherwise in situations where we don't have a working sandbox
(darwin), if /usr/share/emacs happens to exist, the install
phase will try to put its lisp files there and fail due to
permissions.
@risicle risicle force-pushed the ris-gforth-lispdir branch from 5675653 to 27d4500 Compare June 11, 2022 18:14
@risicle risicle merged commit 94c3770 into NixOS:master Jun 11, 2022
@github-actions
Copy link
Contributor

Successfully created backport PR #177323 for release-22.05.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants