Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.uharfbuzz: mark as broken on darwin #172204

Merged
merged 1 commit into from
May 9, 2022
Merged

python3Packages.uharfbuzz: mark as broken on darwin #172204

merged 1 commit into from
May 9, 2022

Conversation

WolfangAukang
Copy link
Contributor

@WolfangAukang WolfangAukang commented May 9, 2022 •
edited
Loading

Description of changes

#172160. I don't own or have a darwin machine, neither want to go further in simulating one to only maintain it. If someone wants to try it, feel free to do it or contact me for testing (if you think it is needed).

The only thing to consider is that ApplicationServices might be a required dependency (Hydra log)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@WolfangAukang WolfangAukang marked this pull request as draft May 9, 2022 14:50
@WolfangAukang WolfangAukang force-pushed the uharfbuzz-darwin branch 2 times, most recently from 5f833a1 to 59d9b68 Compare May 9, 2022 15:00
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 9, 2022
@WolfangAukang WolfangAukang changed the title python3Packages.uharfbuzz: add dependencies for darwin python3Packages.uharfbuzz: mark as broken on darwin May 9, 2022
@WolfangAukang WolfangAukang marked this pull request as ready for review May 9, 2022 16:13
@WolfangAukang
Copy link
Contributor Author

Pinging @NixOS/nixos-release-managers

@davidak davidak added the 0.kind: build failure A package fails to build label May 9, 2022
@davidak
Copy link
Member

davidak commented May 9, 2022

Result of nixpkgs-review pr 172204 run on x86_64-linux 1

davidak
davidak approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Evaluates

@davidak davidak merged commit e2a1802 into NixOS:master May 9, 2022
@WolfangAukang WolfangAukang deleted the uharfbuzz-darwin branch May 9, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
0.kind: build failure A package fails to build 6.topic: darwin Running or building packages on Darwin 6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WolfangAukang @davidak