Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python fixes #169681

Merged
merged 4 commits into from
Apr 24, 2022
Merged

Python fixes #169681

merged 4 commits into from
Apr 24, 2022

Conversation

SuperSandro2000
Copy link
Member

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@samuela
Copy link
Member

samuela commented Apr 22, 2022

Running nixpkgs-review has gotten stuck building openmoji. (Is there a build timeout feature?) But it appears there's 118 failures. We should sort through to figure out which if any of these are new and which are existing.

Here's an abridged error log: https://gist.github.com/samuela/f4dad8455762fe70ef44044140081814

In order to make this more manageable to run nixpkgs-review, I think it'd be simpler if we did separate, smaller PRs for each commit. Is there a reason these changes need to be in a single PR?

@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Apr 23, 2022

In order to make this more manageable to run nixpkgs-review, I think it'd be simpler if we did separate, smaller PRs for each commit. Is there a reason these changes need to be in a single PR?

I am lazy and normally no one takes a look anyway.

Running nixpkgs-review has gotten stuck building openmoji. (Is there a build timeout feature?) But it appears there's 118 failures. We should sort through to figure out which if any of these are new and which are existing.

Here's an abridged error log: gist.github.com/samuela/f4dad8455762fe70ef44044140081814

That is 100% pre existing and unrelated to my changes.

@Artturin
Copy link
Member

Artturin commented Apr 24, 2022

Running nixpkgs-review has gotten stuck building openmoji. (Is there a build timeout feature?) But it appears there's 118 failures. We should sort through to figure out which if any of these are new and which are existing.

#167869

Created a issue for some of the failures #170080

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nixpkgss-current-development-workflow-is-not-sustainable/18741/50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants