-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python fixes #169681
Python fixes #169681
Conversation
Running nixpkgs-review has gotten stuck building openmoji. (Is there a build timeout feature?) But it appears there's 118 failures. We should sort through to figure out which if any of these are new and which are existing. Here's an abridged error log: https://gist.github.com/samuela/f4dad8455762fe70ef44044140081814 In order to make this more manageable to run nixpkgs-review, I think it'd be simpler if we did separate, smaller PRs for each commit. Is there a reason these changes need to be in a single PR? |
I am lazy and normally no one takes a look anyway.
That is 100% pre existing and unrelated to my changes. |
236229c
to
646b9a7
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/nixpkgss-current-development-workflow-is-not-sustainable/18741/50 |
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes