-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emscripten: 2.0.27 -> 3.0.0 #149083
emscripten: 2.0.27 -> 3.0.0 #149083
Conversation
Result of 2 packages marked as broken and skipped:
2 packages failed to build:
25 packages built:
|
|
Seems like fails to build emscripten on aarch64-darwin. Can anyone check? |
@matthewbauer does package.json need to be updated accordingly too? |
@NixOS/darwin-maintainers can any aarch64 users test this out on their machines? |
@willcohen I gave it a try but it fails to download JDK 17 (it looks like the URL is not correct (404)):
I checked the CDN from where it tries to get the JDK for aarch64-darwin and for the the |
Interesting -- if you rebase to master does it still fail? Looks like this |
Sure, I’ll try doing so later this evening.
…On Sun, 20 Mar 2022 at 1:44 pm, Will Cohen ***@***.***> wrote:
Interesting -- if you rebase to master does it still fail?
Looks like this .15 and .19 mess got resolved with 78cad27
<78cad27>
.
—
Reply to this email directly, view it on GitHub
<#149083 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADJEKPW5ZTCDGLJ3VYC3LTVA2GKNANCNFSM5JPHGIWA>
.
You are receiving this because you are on a team that was mentioned.Message
ID: ***@***.***>
|
@damien-biasotto After a rebase to master I could successfully build this on aarch64-darwin. |
Yup, I can confirm it works fine after rebasing on master. Thank you @tricktron for checking it. |
@SuperSandro2000 can this be merged? |
Result of 4 packages failed to build:
1 package built:
|
Thanks @siraben -- still need to diagnose. |
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 2 packages marked as broken and skipped:
2 packages failed to build and already failed to build on hydra master:
25 packages built:
|
Thanks @SuperSandro2000, though while
|
So far for testing purposes, I've tried commenting out the two lines at nixpkgs/pkgs/development/compilers/emscripten/default.nix Lines 51 to 53 in f1108e0
nixpkgs/pkgs/development/em-modules/generic/default.nix Lines 21 to 29 in 6341419
From here, the build proceeds much further, though doesn't quite complete:
|
As a followup, those changes seem to work okay on linux:
|
Note that #172207 seems to address the issues left unresolved here post-merge -- in this case the remaining errors I saw with |
Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/emscripten-core/emscripten/releases.
meta.description for emscripten is: "An LLVM-to-JavaScript Compiler"
meta.homepage for emscripten is: "https://github.com/emscripten-core/emscripten"
meta.changelog for emscripten is: ""
Updates performed
To inspect upstream changes
Release on GitHub
Compare changes on GitHub
Impact
Checks done (click to expand)
passthru.tests
, if any, passedRebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-users
list or you can usesudo
since root is effectively trusted.Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review took longer than 45m and timed out
Maintainer pings
cc @qknight @matthewbauer for testing.