Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mrtrix: 3.0.2 -> unstable-2021-11-25 #148096

Merged
merged 1 commit into from
Dec 1, 2021
Merged

mrtrix: 3.0.2 -> unstable-2021-11-25 #148096

merged 1 commit into from
Dec 1, 2021

Conversation

arkivm
Copy link
Contributor

@arkivm arkivm commented Dec 1, 2021

Motivation for this change

The latest stable version fails to build with latest eigen (> 3).
MRtrix3/mrtrix3#2368

Update to latest unstable master to fix build.
https://hydra.nixos.org/build/158660746

ZHF: #144627

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@arkivm
mrtrix: 3.0.2 -> unstable-2021-11-25
b1d95dc 
The latest stable version fails to build with latest eigen (> 3).
MRtrix3/mrtrix3#2368
@ofborg ofborg bot requested a review from bcdarwin December 1, 2021 05:20
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Dec 1, 2021
@Mic92 Mic92 merged commit e89d789 into NixOS:master Dec 1, 2021
@github-actions github-actions bot mentioned this pull request Dec 1, 2021
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2021

Successfully created backport PR #148118 for release-21.11.

@arkivm arkivm deleted the fix-mrtrix branch December 1, 2021 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcdarwin bcdarwin Awaiting requested review from bcdarwin

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arkivm @Mic92 @bcdarwin