macs: configure cores/jobs per profile #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweinelt
force-pushed
the
mac-split
branch
2 times, most recently
from
e355c82 to
bcd8f6a
Compare
jfly
approved these changes
Jan 16, 2025
macs/m1.nix
Outdated
| @@ -0,0 +1,8 @@ | |||
| { | |||
| # 8C, 16 GB, 256 GB | |||
There was a problem hiding this comment.
uber nit, feel free to ignore: What's the "256 GB"? Is that the size of the disk? Perhaps worth calling out explicitly? ("8 cores, 16 GB RAM, 256 GB storage")
There was a problem hiding this comment.
Yes, these are Macs. The reasoning is, that 256 GB RAM from Apple would bankrupt the foundation, so it cannot be that.
Mic92
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need jobs with larger core counts to accomodate big build jobs, that would otherwise timeout.