Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Kotlin tuple example similar to Swift #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JonLatane
Copy link

@JonLatane JonLatane commented Dec 27, 2016

Why?

  • The tuples example used data classes instead of tuples/Pairs.
  • This was not really analogous to the corresponding Swift implementation.

What changed?

  • Used the to operator function in the tuple example.

@JonLatane JonLatane changed the title Fix Kotlin tuple example Make Kotlin tuple example similar to Swift Dec 28, 2016
@dcow
Copy link

dcow commented May 19, 2017

Just came here to fix this. Already done! Except I don't see it in the diff. Did you forget some commits?

@dcow
Copy link

dcow commented May 19, 2017

Oh I see you just added it at the top.

@alxrm
Copy link

alxrm commented May 19, 2017

@JonLatane, I'm sorry, but that would generally be wrong, because you would not get a Triple<A, B, C>, but this:

Actual type is Pair<Int, Pair<Int, Int>>

(Yeah, I do realise how much outdated my answer is, but still)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants