Skip to content
This repository has been archived by the owner on Apr 19, 2021. It is now read-only.

Improved the feature #25 #35

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Improved the feature #25 #35

wants to merge 5 commits into from

Conversation

Vest
Copy link
Contributor

@Vest Vest commented Jul 27, 2015

Hello @Nilhcem,

I have reviewed my feature and performed a couple of changes. I hope this will work fine on your machine:

  • Windows 8.1/Ubuntu 15.04/Mac 10.10.4 support the "tray" feature (unfortunately, I had to implement a private key that I do not like, but I couldn't resolve platform issues in a neat way. None of solution I have found in Internet are cross-platform);
  • I have re-designed the "minimize" functionality. Now, when a window is closed - it is closed. But if you minimize, it will be "iconified".

Thank you in advance,
Vest

Vest added 4 commits July 27, 2015 20:15
(tested on 10.10.4, Java 1.8)
Changed the behavior of a window minimizing - now if the window is closed, the application is closed as well.
Unfortunately AWT events work slightly different on these platforms. When TrayIcons are used, random errors might appear.
@Vest Vest changed the title Fix/issue25 Improved the feature #25 Jul 27, 2015
…nt better;

Forgot to save the configuration, when the main window is closed;
@Vest
Copy link
Contributor Author

Vest commented Jul 28, 2015

A small comment regarding the pull request: it seems that the TrayIcon feature is quite tricky in different platforms. I hope at least I solved it.
Could you please take a look at my code, and probably test on your current machine just in case?

@Nilhcem
Copy link
Owner

Nilhcem commented Jul 28, 2015

Many thanks, I will check all this when I have some time

@Vest
Copy link
Contributor Author

Vest commented Jul 28, 2015

Ok, thanks.

@Nilhcem
Copy link
Owner

Nilhcem commented Aug 30, 2015

I prefer this version (app getting iconified when minimized).
Merged on master but still disabled by default.

I tested it and it works well on Windows + GNOME (well, there's no minimize button), however it does not seem to work on a Mac OSX (JRE 1.8.0_60-b27), when pressing the minimize button it goes to the dock and disappears right away

@Vest
Copy link
Contributor Author

Vest commented Aug 30, 2015

Oh, I really sorry again.
When my Mac is repaired, I will check my coding. Let us keep this feature disabled.

@Nilhcem
Copy link
Owner

Nilhcem commented Aug 30, 2015

Sorry too, I don't have time to investigate also. If this is too complicated or involves writing too much code, maybe we can just disable the feature for mac users (we need to make sure it works well on Linux Desktop Environments first)

@Vest
Copy link
Contributor Author

Vest commented Aug 30, 2015

It doesn't require much code, or at least my last version. This kind of low-level stuff requires some magic and luck.
E.g. I had to always experiment and verify changes in every platform.
But thanks again. I will probably do as you said.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants