Update DbusInterfaceBase.js #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix the issue of accumulating listeners
|
@Niels-Be : Request you to check it. This causes memory leaks in long running applications. The node hangs randomly and then generates a memory leak |
|
The forwardPropertyChange should be removed when there are no more PropertyChange listeners. I don`t think this PR would change anything from this behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the issue of accumulating listeners. The issue of accumulating listeners occurs because the code does not remove the forwardPropertyChange listener from the property interface when the DbusInterfaceBase instance is destroyed or when the PropertiesChanged event is no longer needed.