Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZoneEdit certbot plugin #4208

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

badkeyy
Copy link
Contributor

@badkeyy badkeyy commented Dec 4, 2024

Fixes #4171 without the whitespace issues from #4188.

Credits to #4188 - I hadn’t noticed this PR when I initially added ZoneEdit. Given that it has been a week since the whitespace issues, I decided to move forward and publish my PR to help maintain a faster development cycle.

@badkeyy badkeyy force-pushed the feature/add-zone-edit-certbot-plugin branch from 9551d9d to 1e32280 Compare December 4, 2024 15:47
@nginxproxymanagerci
Copy link

Docker Image for build 2 is available on
DockerHub
as nginxproxymanager/nginx-proxy-manager-dev:pr-4208

Note: ensure you backup your NPM instance before testing this image! Especially if there are database changes
Note: this is a different docker image namespace than the official image

@kerstenremco
Copy link
Contributor

Thank you! I closed #4188

@jc21
Copy link
Member

jc21 commented Dec 16, 2024

Thanks, but I just need someone to confirm that this works as expected using the test docker image above.

@jc21 jc21 added requires-verification Waiting for one or more people to confirm the fix dns provider request This issue is a request to integrate a new DNS-challenge provider and removed dns provider request This issue is a request to integrate a new DNS-challenge provider labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires-verification Waiting for one or more people to confirm the fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZoneEdit - DNS challenge provider request
3 participants