Pooled span dicitionary direct pointer #455
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
PooledSpanDictionary
to use pointers rather than relative addresses that need to then transformed before accessing. This unfortunately makes the address size twice as big (fromuint
tobyte*
). When theRoot
PageCount
is increased to make it big enough to keep the same number of buckets (128kb
for the root instead of the earlier64kb
), the new version wins.Benchmarks
Read_write_small
has been modified.Before pointer
After pointer and 2 times bigger Root