Embed Youtube video player not loading as expected after accepting cookies #207 #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add modal top bar * Add opening the links with modal link * Refactor the modal background color * Improve modal accessibility --------- Authored-by: Tomasz Dziezyk <[email protected]>
* add countdown timer in hero block * refactor gaps, UI improvements for all variants * fix button padding for tablet * better text wrapping * fix hero container takes at least the height of the viewport, and in case of overflow content, the height expands * update hero gradient * add variant to right align background in hero * refactor better class names for positioning * fix hero background * add play icon --------- Co-authored-by: Syb Wartna <[email protected]>
* Resources gallery #87
cogniSyb
requested review from
TomaszDziezykNetcentric,
markovukiceviccn and
taimurCognizant
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
markovukiceviccn
approved these changes
Dec 15, 2023
TomaszDziezykNetcentric
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #207
Test URLs:
In below screenshot you see the initial OneTrust groups set on an iPhone with US internet connection. After accepting the cookies, you get a different order of those groups. My code change makes sure that we don’t sort the groups before comparing them. Only if there’s a difference in the comparison, the page will reload. The code change has a downside; we can have situations where we have unnecessary reloads. Though this code will not be executed that much :)
OneTrust can be interacted with on production, so we can test this on production only. I’ve created my own setup with a real iPhone, connected to a VPN and overriding the JS source from Safari on a connected MacBook.